feat(ui): add showFailedIndicator parameter into StreamMessageWidget #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinhHuynh
changed the title
TinhHuynh
force-pushed
the
feat/show-fail-indicator
branch
4 times, most recently
from
941142c to
97ad4c5
Compare
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
fe84adf to
2a25a34
Compare
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
8f6de9a to
794614d
Compare
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
794614d to
aeccb80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
=======================================
Coverage 60.20% 60.20%
=======================================
Files 317 317
Lines 18511 18515 +4
=======================================
+ Hits 11144 11147 +3
- Misses 7367 7368 +1 ☔ View full report in Codecov by Sentry. |
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
b582b65 to
81f48c4
Compare
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
81f48c4 to
7e314f8
Compare
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
7e314f8 to
0ef0fa9
Compare
cogivn
force-pushed
the
feat/show-fail-indicator
branch
from
0ef0fa9 to
4ec9010
Compare
Member
|
Hey, Thank you for the PR but we don't think it's valid to provide an option to hide the failed indicator even when the message is failed to sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
This PR added
showFailedIndicatorparameter into StreamMessageWidget to toggle displaying the failed message icon.